The crotch opening should be made a little lower, for a nicer look.
Really not bad, but you should make it like a chaps. the "bridge" between the legs feels and looks a little bit strange. The front hole is to big /to high. there is to much of the inguinal region seenable. The backhole is perfect